From: David Miller <davem@davemloft.net>
To: sonnyrao@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, miltonm@bga.com, ron.mercer@qlogic.com,
linux-driver@qlogic.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
Date: Mon, 22 Nov 2010 08:29:43 -0800 (PST) [thread overview]
Message-ID: <20101122.082943.104076370.davem@davemloft.net> (raw)
In-Reply-To: <1290075903-3038-1-git-send-email-sonnyrao@linux.vnet.ibm.com>
From: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Date: Thu, 18 Nov 2010 04:25:03 -0600
> Driver appears to be mistaking the permission field with default value
> in the case of debug and qlge_irq_type.
>
> Driver is also passing debug as a bitmask into netif_msg_init()
> which really wants a number of bits, so fix that.
>
> Signed-off-by: Milton Miller <miltonm@bga.com>
> Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Applied, thanks Sonny.
next prev parent reply other threads:[~2010-11-22 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 10:25 Sonny Rao
2010-11-18 17:22 ` Ron Mercer
2010-11-18 19:30 ` David Miller
2010-11-22 16:29 ` David Miller [this message]
2010-11-18 21:50 Sonny Rao
2010-11-18 22:17 ` Ron Mercer
2010-11-18 23:12 ` Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122.082943.104076370.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=sonnyrao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome