Re: [PATCH] Add BTN_TOOL_BUTTONS to input.h

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Ping,

On Thu, Nov 18, 2010 at 04:25:35PM -0800, Ping Cheng wrote:
> We "borrowed" BTN_TOOL_FINGER from input/mouse to pass tablet
> buttons to the user land. This has not been an issue since
> tablet was not considered as a mouse replacement. With the
> introduction of hybrid digitizer and touch devices, the tool
> type is causing confusion. A new tool type is due for the
> well-being of future input device drivers.
> 

I am sorry but I do not understand the reasoning behind
BTN_TOOL_BUTTONS.

The BTN_TOOL_* were introduced to indicate to the userspace tool that is
currently touching the surface of the device. Buttons are expected to be
always present and can change their state regardless of what tool is
being used at the moment. I.e. The full hardware state (between
EV_SYN/SYN_REPORT) could be, for example,

Pen at 10,20, BTN_0, and BTN_2 (ABS_X 10, ABS_Y 20, BTN_TOOL_PEN, BTN_0,
BTN_2) or

Lens at 20,15 and BTN_1 (ABS_X 20, ABS_Y 15, BTN_TOOL_LENS, BTN_1).

As you can see BTN_* events can accompany either BTN_TOOL_LENS or
BTN_TOOL_PEN or any other BTN_TOOL_*.

Thanks.

-- 
Dmitry