Re: [PATCH repost 3] [SCSI] Retrieve the Caching mode page

[Matthew Dharm <mdharm-kernel@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

On Tue, Nov 23, 2010 at 01:25:23AM -0800, Luben Tuikov wrote:
> --- On Mon, 11/22/10, Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
> wrote:
> 
> > What are the consequences if the device returns what appear to be a
> > Caching Mode Page, but it is actually filled with garbage or otherwise
> > inaccurate data?
> 
> Data corruption would be no different than when determining whether the
> media is write protected or determining other parameters. A similar
> question would be "What would the consequences be if the device
> misreported the media write-protect bit?" I suppose such a device would
> be quite broken and inoperative.

Not really.  In your example case of the write-protect bit, either the
device would be improperly marked as write-protected when it is not, or we
would improperly send write commands to a protected device.  Neither is a
great tradgedy; commands will fail, errors will be generated, and life will
go on.

However, I don't know what is in the Caching Mode Page.  I don't know how
those bits are used to determine the behavior of the rest of the kernel.
Maybe one of those bits means "only store data in Japanese" or something
equally disturbing.

The old code used to make a "safe" default choice if the caching mode page
was not available (for whatever reason).   What are the implications of not
making the "safe" choice improperly (due to mode page corruption)?

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

I need a computer?
					-- Customer
User Friendly, 2/19/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]