mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kyle McMartin <kyle@mcmartin.ca>
To: Len Brown <lenb@kernel.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>,
	linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [RFT][PATCH] Poke ACPI about connected floppy drives
Date: Thu, 25 Nov 2010 13:04:00 -0500	[thread overview]
Message-ID: <20101125180400.GI22651@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1011242153330.637@x980>

On Wed, Nov 24, 2010 at 10:57:22PM -0500, Len Brown wrote:
> I have 45 DSDTs on-hand that include PNP0700,
> but only 18 of those implement _FDE...
> 

Awesome, thanks for testing. Poking people to test the module on their
machines I saw pretty much the same experiences. A lot of tables that
do have _FDE seem to wire it to One if there's a floppy controller,
regardless of whether a drive is wired.

Pretty much makes it useless for what I was hoping to use it for
(avoiding probing floppies on machines without them attached, since it
 sometimes takes quite a while.)

> I have a Lenovo T61 which has PNP0700 and implements _FDE.
> However, it doesn't physically have a floppy, and so
> acpi_fde_add() will never get called -- I guess
> because _CRS said it wasn't present?  This seems
> to make evaluating _FDE from the .add routine
> somewhat redundant, no?
> 

I'm not sure what _CRS is, so I don't know. :/ I'll look it up.

> Note that you've got a memory leak in acpi_fde_add()
> in the "if (!c)" case.  Also, "rmmod floppy" takes an oops.
> 

Oops, sorry, it was just for testing so I didn't bother checking those.

Not sure the patch is worth the effort given how few DSDTs implement
_FDE though.

regards, Kyle

> cheers,
> Len Brown, Intel Open Source Technology Center
> 

      reply	other threads:[~2010-11-25 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 18:24 Kyle McMartin
2010-11-25  3:57 ` Len Brown
2010-11-25 18:04   ` Kyle McMartin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101125180400.GI22651@bombadil.infradead.org \
    --to=kyle@mcmartin.ca \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®