From: Ingo Molnar <mingo@elte.hu>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jason Baron <jbaron@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp,
Masami Hiramatsu <mhiramat@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH -tip v4 3/3] kprobes: Support delayed unoptimization
Date: Fri, 26 Nov 2010 08:26:21 +0100 [thread overview]
Message-ID: <20101126072621.GB19589@elte.hu> (raw)
In-Reply-To: <20101119100948.16882.24259.stgit@ltc236.sdl.hitachi.co.jp>
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> Unoptimization occurs when a probe is unregistered or disabled, and
> is heavy because it recovers instructions by using stop_machine().
> This patch delays unoptimization operations and unoptimize several
> probes at once by using text_poke_smp_batch().
> This can avoid unexpected system slowdown coming from stop_machine().
>
> Changes in v2:
> - Use dynamic allocated buffers and params.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: linux-kernel@vger.kernel.org
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> ---
>
> arch/x86/include/asm/kprobes.h | 4
> arch/x86/kernel/kprobes.c | 45 ++++
> include/linux/kprobes.h | 2
> kernel/kprobes.c | 434 +++++++++++++++++++++++++++-------------
> 4 files changed, 344 insertions(+), 141 deletions(-)
Hm, this is a scary big patch with non-trivial effects - it should be broken up as
much as possible, into successive, bisectable steps. The end result looks mostly
fine - it's just this one huge step of a patch that is dangerous.
Thanks,
Ingo
next prev parent reply other threads:[~2010-11-26 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 10:09 [PATCH -tip v4 0/3] Kprobes/x86: Batch optimization support Masami Hiramatsu
2010-11-19 10:09 ` [PATCH -tip v4 1/3] x86: Introduce text_poke_smp_batch() for batch-code modifying Masami Hiramatsu
2010-11-19 10:09 ` [PATCH -tip v4 2/3] kprobes/x86: Use text_poke_smp_batch Masami Hiramatsu
2010-11-19 10:09 ` [PATCH -tip v4 3/3] kprobes: Support delayed unoptimization Masami Hiramatsu
2010-11-26 7:26 ` Ingo Molnar [this message]
2010-11-26 9:27 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126072621.GB19589@elte.hu \
--to=mingo@elte.hu \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=ananth@in.ibm.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®