From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832Ab0K2Tqn (ORCPT ); Mon, 29 Nov 2010 14:46:43 -0500 Received: from kroah.org ([198.145.64.141]:54571 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514Ab0K2TqZ (ORCPT ); Mon, 29 Nov 2010 14:46:25 -0500 Date: Mon, 29 Nov 2010 11:44:14 -0800 From: Greg KH To: Belisko Marek Cc: Jiri Slaby , devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] staging: ft1000: Use misc device instead self created device. Message-ID: <20101129194414.GB14086@kroah.com> References: <1290515373-16145-1-git-send-email-marek.belisko@open-nandra.com> <1290515373-16145-3-git-send-email-marek.belisko@open-nandra.com> <4CEBC751.6090906@gmail.com> <4CEC3211.7050503@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 24, 2010 at 10:16:36AM +0100, Belisko Marek wrote: > On Tue, Nov 23, 2010 at 10:28 PM, Jiri Slaby wrote: > > On 11/23/2010 03:00 PM, Belisko Marek wrote: > >> On Tue, Nov 23, 2010 at 2:53 PM, Jiri Slaby wrote: > >>> On 11/23/2010 01:29 PM, Marek Belisko wrote: > >>>> Use simple misc device for ioctl driver funtionality testing. > >>>> > >>>> Signed-off-by: Marek Belisko > >>>> --- > >>>>  drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c |   90 ++++++++++++++++++--- > >>>>  1 files changed, 77 insertions(+), 13 deletions(-) > >>>> > >>>> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > >>>> index 1aec926..d1784a3 100644 > >>>> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > >>>> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c > >>>> @@ -32,6 +32,7 @@ > >>>>  #include > >>>>  #include > >>>>  #include > >>>> +#include > >>>> > >>>>  #include > >>>>  #include > >>>> @@ -78,6 +79,47 @@ static struct file_operations ft1000fops = > >>>>       .llseek         = no_llseek, > >>>>  }; > >>>> > >>>> +struct ft1000_misc_device { > >>>> +     struct miscdevice dev; > >>>> +     int inf_id; > >>>> +}; > >>>> + > >>>> +#define FREE_ID (0xFF) > >>>> + > >>>> +/* we support just 3 devices */ > >>>> +#define MAX_DEVICE 3 > >>> > >>> No, why this should be converted to miscdevice? Leave it as chrdev. > >> Is there any problem with using miscdev? > > > > Yes, if you want more than a single device per system. > > > >> Old interface create /dev nodes with > >> calling kernel thread and some usermode_helper or whatever. > > > > Yes, that's crap indeed. But doesn't judge for miscdevice. > > > >> Just convert to misc dev > >> where this is done automatically. > > > > So the only thing you need to do is to send a uevent to udev appropriately. > Could be used something like: > register_chrdev(0,"ft1000", &fops) > class = class_create(THIS_MODULE, "ft1000"); > device_create(class, NULL, MKDEV(major, i), NULL, "ft1000%d", i); > Then will be created different devices for every plugged device. > This should have effect of automatic device node creation also suppose. Please don't create new classes. Is this a USB device? If so, why not just use the USB major number? Just ask me and I can reserve you a USB minor number for your driver. thanks, greg k-h