From: Pavel Machek <pavel@ucw.cz>
To: linux-kernel@vger.kernel.org
Cc: ecc@cmu.edu
Subject: Re: [PATCH] add netdev led trigger
Date: Tue, 30 Nov 2010 20:20:53 +0100 [thread overview]
Message-ID: <20101130192053.GB5295@ucw.cz> (raw)
In-Reply-To: <20101117200614.GK15096@localhost>
Please preserve cc lists.
> > I was hoping you'd comment on the ABI itself, too. It uses
> >
> > echo "foo bar baz" > file
> >
> > to enable/disable specific events to be "displayed". More traditional
> > interface would be
> >
> > echo disable > file_foo
>
> The main arguments for using the single "mode" file are:
> 1. that's how it was implemented for OpenWrt, and there's a fair
> amount of userland (web admin tools, etc.) that groks it
That's not good reason...
> 2. it's only specifying a set of three possible values -- separate
> files seem like overkill
Does it? AFAICT it allowed any combination of 3 -- IOW 2^3 values.
Please be consistent with rest of kernel...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2010-11-30 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 20:58 Eric Cooper
2010-11-15 23:41 ` Lars-Peter Clausen
2010-11-17 11:05 ` Pavel Machek
2010-11-17 16:09 ` Greg KH
2010-11-17 19:58 ` Pavel Machek
2010-11-17 20:01 ` Greg KH
2010-11-17 20:06 ` Eric Cooper
2010-11-30 19:20 ` Pavel Machek [this message]
2010-11-30 23:22 ` Eric Cooper
2010-12-01 19:56 ` Pavel Machek
2010-11-21 20:53 ` Eric Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130192053.GB5295@ucw.cz \
--to=pavel@ucw.cz \
--cc=ecc@cmu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®