mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Namhyung Kim <namhyung@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] USB: whci-hcd: move whci_hcd_id_table under #ifdef MODULE
Date: Wed, 1 Dec 2010 11:37:12 -0800	[thread overview]
Message-ID: <20101201193712.GA918@suse.de> (raw)
In-Reply-To: <1291225529-1118-1-git-send-email-namhyung@gmail.com>

On Thu, Dec 02, 2010 at 02:45:27AM +0900, Namhyung Kim wrote:
> Since whci_hcd_id_table is used only for module auto-loading
> move it under #ifdef MODULE. This fixes following warning:
> 
>   CC      drivers/usb/host/whci/hcd.o
> drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> 
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
>  drivers/usb/host/whci/hcd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c
> index 72b6892..ee76401 100644
> --- a/drivers/usb/host/whci/hcd.c
> +++ b/drivers/usb/host/whci/hcd.c
> @@ -355,12 +355,14 @@ static void __exit whci_hc_driver_exit(void)
>  }
>  module_exit(whci_hc_driver_exit);
>  
> +#ifdef MODULE

Ick, no, please just use the __used type instead.  We don't want #ifdefs
in .c files if at all possible.

Same goes for the other 2 patches, care to redo them as well?

thanks,

greg k-h

  parent reply	other threads:[~2010-12-01 19:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 17:45 Namhyung Kim
2010-12-01 17:45 ` [PATCH 2/3] uwb: move whcrc_id_table " Namhyung Kim
2010-12-01 17:45 ` [PATCH 3/3] uwb: move i1480_est_id_table " Namhyung Kim
2010-12-01 19:37 ` Greg KH [this message]
2010-12-01 20:32   ` [PATCH 1/3] USB: whci-hcd: move whci_hcd_id_table " Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201193712.GA918@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=namhyung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome