From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC] perf: Prevent potential null dereference
Date: Fri, 3 Dec 2010 01:48:16 +0300 [thread overview]
Message-ID: <20101202224816.GB6471@lenovo> (raw)
In-Reply-To: <20101202224609.GA31473@ghostprotocols.net>
On Thu, Dec 02, 2010 at 08:46:10PM -0200, Arnaldo Carvalho de Melo wrote:
...
> > > It seems exit right here is more convenient than passing error
> > > handling level up (which would have to exit anyway), thought
> > > if handling it "upper" is preferred -- just say a word.
> > >
> >
> > Good.
> >
> > As a nit, not that it matters that much because we are very close to the starting code
> > anyway, but it would be better to propagate the error to the callers.
>
> I'm of the opinion that main() should be where exit() is allowed, and
> even there... return would be better. 8-)
>
> - Arnaldo
>
ok, i'll update tomorrow (almost off).
Cyrill
next prev parent reply other threads:[~2010-12-02 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 22:26 Cyrill Gorcunov
2010-12-02 22:41 ` Frederic Weisbecker
2010-12-02 22:46 ` Arnaldo Carvalho de Melo
2010-12-02 22:48 ` Cyrill Gorcunov [this message]
2010-12-05 22:13 ` Cyrill Gorcunov
2010-12-06 14:49 ` Arnaldo Carvalho de Melo
2010-12-06 14:59 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202224816.GB6471@lenovo \
--to=gorcunov@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®