From: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
To: stummala@codeaurora.org
Cc: Hein_Tibosch <hein_tibosch@yahoo.es>,
Andrew Morton <akpm@linux-foundation.org>,
Pierre Ossman <pierre@ossman.eu>, Chris Ball <cjb@laptop.org>,
Ben Nizette <bn@niasdigital.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Adrian Hunter <adrian.hunter@nokia.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matt Fleming <matt@console-pimps.org>
Subject: Re: [PATCH v4] mmc: Make ID freq configurable
Date: Fri, 3 Dec 2010 07:56:12 +0100 [thread overview]
Message-ID: <20101203065612.GA9779@rere.qmqm.pl> (raw)
In-Reply-To: <1c6eadd860e1a9085336bf75a2a96eb3.squirrel@www.codeaurora.org>
On Thu, Dec 02, 2010 at 09:05:54PM -0800, stummala@codeaurora.org wrote:
> Hi Michal,
[...]
> >> > In case of SDIO error, mmc_power_off() is getting called as part of
> >> > mmc_detach_bus(). Shouldn't we power up the host before checking for
> >> > SDMEM? Any comments?
> >> I think you should ask Michal Miroslaw, as he wrote the patch for the
> >> SD-combo (IO + mem)*
> >>
> >> But yes, in case of a failure, mmc_attach_sdio() will call
> >> mmc_detach_bus()
> >> which in turn will call mmc_power_off()
> >>
> >> And so it should be mmc_power_up() again before trying to detect SD
> >> memory.
> > Yes, you are right! This explains some things...
> >
> > Please try attached patch. (Not tested, but obvious enough.)
> I was looking at the code and figured out this issue. I don't have any
> SD-combo card to verify your patch.
You shouldn't be able to use this code path with normal SD-combo cards.
This is relevant if you have a card that responds to CMD5 but then fails
SDIO part initialization in some circumstances (i.e. time-outs).
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2010-12-03 6:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 21:34 Hein_Tibosch
2010-09-03 1:47 ` Chris Ball
2010-09-03 23:25 ` Andrew Morton
2010-09-05 20:14 ` Matt Fleming
2010-09-05 20:43 ` Chris Ball
2010-09-05 21:22 ` Matt Fleming
2010-09-06 1:37 ` [PATCH v5] " Hein_Tibosch
2010-12-02 11:16 ` [PATCH v4] " Sahitya Tummala
2010-12-02 21:21 ` Hein_Tibosch
2010-12-02 22:38 ` Michal Miroslaw
2010-12-03 5:05 ` stummala
2010-12-03 6:56 ` Michal Miroslaw [this message]
2010-12-17 1:09 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203065612.GA9779@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=bn@niasdigital.com \
--cc=cjb@laptop.org \
--cc=hein_tibosch@yahoo.es \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=pierre@ossman.eu \
--cc=s.hauer@pengutronix.de \
--cc=stummala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®