Re: [PATCH] arm: ecard: Fix compilation warning.

[Russell King - ARM Linux <linux@arm.linux.org.uk>]

On Mon, Dec 06, 2010 at 03:04:03PM +0100, Marek Belisko wrote:
> Fix following compilation warning:
> arch/arm/kernel/ecard.c:1066: warning: ignoring return value of
> 'device_register', declared with attribute warn_unused_result
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  arch/arm/kernel/ecard.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
> index eed2f79..da882b1 100644
> --- a/arch/arm/kernel/ecard.c
> +++ b/arch/arm/kernel/ecard.c
> @@ -1063,8 +1063,10 @@ ecard_probe(int slot, card_type_t type)
>  	*ecp = ec;
>  	slot_to_expcard[slot] = ec;
>  
> -	device_register(&ec->dev);
> -
> +	rc = device_register(&ec->dev);
> +	if (rc)
> +		goto nodev;
> +
>  	return 0;

No.  It is important that cards which are actually there remain present
even if device_register fails.  In other words, we _really_ don't care
what device_register() returns.