From: Greg KH <greg@kroah.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: whci-hcd: fix compiler warning
Date: Mon, 6 Dec 2010 07:56:25 -0800 [thread overview]
Message-ID: <20101206155625.GC23214@kroah.com> (raw)
In-Reply-To: <1291640730.1696.29.camel@leonhard>
On Mon, Dec 06, 2010 at 10:05:30PM +0900, Namhyung Kim wrote:
> 2010-12-01 (수), 09:36 -0800, Greg KH:
> > On Thu, Dec 02, 2010 at 01:49:11AM +0900, Namhyung Kim wrote:
> > > 2010-12-01 (수), 08:10 -0800, Greg KH:
> > > > On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> > > > > Annotate whci_hcd_id_table as '__used' to fix following warning:
> > > > >
> > > > > CC drivers/usb/host/whci/hcd.o
> > > > > drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> > > >
> > > > Are you seeing this warning when you build the module into the kernel,
> > > > or as a module?
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > I saw it during allyesconfig build but not on allmodconfig.
> > > Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
> >
> > No, don't do that, your __used is the correct thing here, I just wanted
> > to make sure why you were seeing this warning.
> >
> > thanks,
> >
> > greg k-h
>
> Hi, Greg
>
> It seems this one is not applied in your tree yet. Do you need a resend?
Yes please, I must have missed it, thinking it was part of your other
series. Sorry.
greg k-h
next prev parent reply other threads:[~2010-12-06 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 4:28 Namhyung Kim
2010-12-01 16:10 ` Greg KH
2010-12-01 16:49 ` Namhyung Kim
2010-12-01 16:52 ` David Vrabel
2010-12-01 17:02 ` Namhyung Kim
2010-12-01 17:06 ` David Vrabel
2010-12-01 17:11 ` Namhyung Kim
2010-12-01 17:36 ` Greg KH
2010-12-06 13:05 ` Namhyung Kim
2010-12-06 15:56 ` Greg KH [this message]
2010-12-06 16:03 ` [PATCH RESEND] " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206155625.GC23214@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome