mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
To: namhyung@gmail.com (Namhyung Kim)
Cc: jwoithe@physics.adelaide.edu.au (Jonathan Woithe),
	mjg@redhat.com (Matthew Garrett),
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fujitsu-laptop: fix compiler warning on pnp_ids
Date: Wed, 8 Dec 2010 08:49:11 +1030 (CST)	[thread overview]
Message-ID: <201012072219.oB7MJBgm020656@turbo.physics.adelaide.edu.au> (raw)
In-Reply-To: <1291734254-12250-1-git-send-email-namhyung@gmail.com> from "Namhyung Kim" at Dec 08, 2010 12:04:14 AM

Looks fine to me.

Acked-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>

> Annotate pnp_ids as '__used' to fix following warning:
> 
>   CC      drivers/platform/x86/fujitsu-laptop.o
> drivers/platform/x86/fujitsu-laptop.c:1243: warning: ‘pnp_ids’ defined but not used
> 
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> ---
>  drivers/platform/x86/fujitsu-laptop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index f44cd26..ad88b2e 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -1240,7 +1240,7 @@ MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1D3:*:cvrS6410:*");
>  MODULE_ALIAS("dmi:*:svnFUJITSUSIEMENS:*:pvr:rvnFUJITSU:rnFJNB1E6:*:cvrS6420:*");
>  MODULE_ALIAS("dmi:*:svnFUJITSU:*:pvr:rvnFUJITSU:rnFJNB19C:*:cvrS7020:*");
>  
> -static struct pnp_device_id pnp_ids[] = {
> +static struct pnp_device_id pnp_ids[] __used = {
>  	{.id = "FUJ02bf"},
>  	{.id = "FUJ02B1"},
>  	{.id = "FUJ02E3"},
> -- 
> 1.7.0.4


      reply	other threads:[~2010-12-07 22:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 15:04 Namhyung Kim
2010-12-07 22:19 ` Jonathan Woithe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201012072219.oB7MJBgm020656@turbo.physics.adelaide.edu.au \
    --to=jwoithe@physics.adelaide.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=namhyung@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®