From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755190Ab0LIJ2v (ORCPT ); Thu, 9 Dec 2010 04:28:51 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:39044 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754830Ab0LIJ2r (ORCPT ); Thu, 9 Dec 2010 04:28:47 -0500 Date: Thu, 9 Dec 2010 10:28:04 +0100 From: Francois Romieu To: "Rafael J. Wysocki" Cc: David Miller , Matthew Garrett , netdev@vger.kernel.org, LKML , Linux-pm mailing list Subject: Re: [PATCH, post-2.6.36 regression fix] r8169: Fix runtime power management Message-ID: <20101209092804.GA4113@electric-eye.fr.zoreil.com> References: <201012090232.14375.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012090232.14375.rjw@sisk.pl> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rafael J. Wysocki : [...] > I noticed that one of the post-2.6.36 patches broke runtime PM of the > r8169 on my MSI Wind test machine in such a way that the link was not > brought up after reconnecting the network cable. > > In the process of debugging the issue I realized that we only should > invoke the runtime PM functions in rtl8169_check_link_status() when > link change is reported and if we do so, the problem goes away. > Moreover, this allows rtl8169_runtime_idle() to be simplified quite > a bit. > > Signed-off-by: Rafael J. Wysocki Acked-by: Francois Romieu -- Ueimor