From: Lasse Collin <lasse.collin@tukaani.org>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org,
Linux Embedded Maillist <linux-embedded@vger.kernel.org>
Subject: Re: [PATCH 2/2] Squashfs: Add XZ compression configuration option
Date: Thu, 9 Dec 2010 11:09:31 +0200 [thread overview]
Message-ID: <201012091109.32084.lasse.collin@tukaani.org> (raw)
In-Reply-To: <4D007315.1090704@lougher.demon.co.uk>
On 2010-12-09 Phillip Lougher wrote:
> +config SQUASHFS_XZ
> + bool "Include support for XZ compressed file systems"
> + depends on SQUASHFS
> + default n
> + select XZ_DEC
Should "select XZ_DEC" be replaced with "depends on XZ_DEC"? XZ_DEC
requires CRC32, so if "select XZ_DEC" is used, there needs to be also
"select CRC32".
XZ_DEC may optionally use other XZ_DEC_* symbols, which the user will
want to choose when building for an embedded system. With "depends on
XZ_DEC" the user will see that there's more than a single option that
affects the details of the XZ support in Squashfs.
--
Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
next prev parent reply other threads:[~2010-12-09 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 6:11 Phillip Lougher
2010-12-09 7:02 ` Geert Uytterhoeven
2010-12-10 6:23 ` Phillip Lougher
2011-01-16 18:56 ` Geert Uytterhoeven
2010-12-09 9:09 ` Lasse Collin [this message]
2010-12-10 7:30 ` Phillip Lougher
2010-12-10 10:37 ` Lasse Collin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012091109.32084.lasse.collin@tukaani.org \
--to=lasse.collin@tukaani.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®