From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: bookjovi@gmail.com
Cc: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org,
viro@zeniv.linux.org.uk, rientjes@google.com, hch@lst.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: fix single_open usage
Date: Fri, 10 Dec 2010 19:17:41 +0900 (JST) [thread overview]
Message-ID: <20101209151039.C79A.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <1291695703-2093-1-git-send-email-bookjovi@gmail.com>
> fix some single_open function usage, use private_data as parameter
>
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
>
> fs/proc/base.c | 29 +++--------------------------
> 1 files changed, 3 insertions(+), 26 deletions(-)
Looks good to me.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index f3d02ca..74a7d92 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -751,14 +751,7 @@ static int proc_single_show(struct seq_file *m, void *v)
>
> static int proc_single_open(struct inode *inode, struct file *filp)
> {
> - int ret;
> - ret = single_open(filp, proc_single_show, NULL);
> - if (!ret) {
> - struct seq_file *m = filp->private_data;
> -
> - m->private = inode;
> - }
> - return ret;
> + return single_open(filp, proc_single_show, inode);
> }
>
> static const struct file_operations proc_single_file_operations = {
> @@ -1386,15 +1379,7 @@ sched_write(struct file *file, const char __user *buf,
>
> static int sched_open(struct inode *inode, struct file *filp)
> {
> - int ret;
> -
> - ret = single_open(filp, sched_show, NULL);
> - if (!ret) {
> - struct seq_file *m = filp->private_data;
> -
> - m->private = inode;
> - }
> - return ret;
> + return single_open(filp, sched_show, inode);
> }
>
> static const struct file_operations proc_pid_sched_operations = {
> @@ -1454,15 +1439,7 @@ static int comm_show(struct seq_file *m, void *v)
>
> static int comm_open(struct inode *inode, struct file *filp)
> {
> - int ret;
> -
> - ret = single_open(filp, comm_show, NULL);
> - if (!ret) {
> - struct seq_file *m = filp->private_data;
> -
> - m->private = inode;
> - }
> - return ret;
> + return single_open(filp, comm_show, inode);
> }
>
> static const struct file_operations proc_pid_set_comm_operations = {
prev parent reply other threads:[~2010-12-10 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 4:21 bookjovi
2010-12-08 21:13 ` David Rientjes
2010-12-10 10:17 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209151039.C79A.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=bookjovi@gmail.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®