mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] x86: Fix warning in hw_nmi.c
Date: Thu, 9 Dec 2010 10:20:33 -0500	[thread overview]
Message-ID: <20101209152033.GU21786@redhat.com> (raw)
In-Reply-To: <AANLkTi=rcc38QzoKa6LFy4m++-p_9=Zt4_kDQE=GeKxf@mail.gmail.com>

On Thu, Dec 09, 2010 at 02:47:34PM +0600, Rakib Mullick wrote:
> commit 0e2af2a9abf94b408ff70679b692a8644fed4aab fixed this warning, it
> again introduced by commit 5f2b0ba4d94b3ac23cbc4b7f675d98eb677a760a.
> This patch fixes it by moving arch_trigger_all_cpu_backtrace few lines
> above backtrace_mask's declaration.
> 
> We were warned by the following warning:
> 
> arch/x86/kernel/apic/hw_nmi.c:29: warning: ‘backtrace_mask’ defined but not used
> 
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>

Thanks Rakib.

I already have this fix lined up for Ingo in another patch series.

http://thread.gmane.org/gmane.linux.kernel/1069682/focus=1069960

Hopefully Ingo will get a chance to include it soon.

Cheers,
Don

      parent reply	other threads:[~2010-12-09 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-09  8:47 Rakib Mullick
2010-12-09 15:09 ` [tip:perf/core] x86: Address 'unused' warning in hw_nmi.c again tip-bot for Rakib Mullick
2010-12-09 15:20 ` Don Zickus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101209152033.GU21786@redhat.com \
    --to=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rakib.mullick@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome