From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>, Ping Cheng <pingc@wacom.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] input: mt: Support separate contact and finger count reports
Date: Sun, 12 Dec 2010 18:34:31 -0800 [thread overview]
Message-ID: <20101213023430.GB21401@core.coreip.homeip.net> (raw)
In-Reply-To: <1292063308-15327-1-git-send-email-rydberg@euromail.se>
On Sat, Dec 11, 2010 at 11:28:27AM +0100, Henrik Rydberg wrote:
> A number of old and semi-recent touch devices are capable of counting
> the number of fingers on the pad within being able to give details for
> all individual contacts. This patch simplifies reporting for such
> hardware by providing a separate function for finger count.
>
Looks good, just a couple nits below.
>
> /**
> + * input_mt_report_finger_count() - report contact count via buttons
"via buttons" is awkward, I'd simply dropped it,
> + * @dev: input device with allocated MT slots
> + * @count: the number of contacts
> + *
> + * Reports the contact count via BTN_TOOL_FINGER, BTN_TOOL_DOUBLETAP,
> + * BTN_TOOL_TRIPLETAP and BTN_TOOL_QUADTAP.
> + *
> + * The input core ensures only the KEY axes already setup for
s/axes/events/ ?
--
Dmitry
next parent reply other threads:[~2010-12-13 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1292063308-15327-1-git-send-email-rydberg@euromail.se>
2010-12-13 2:34 ` Dmitry Torokhov [this message]
[not found] ` <1292063308-15327-2-git-send-email-rydberg@euromail.se>
2010-12-13 2:50 ` [PATCH 2/2] input: mt: Add button support for five fingers Dmitry Torokhov
2010-12-13 8:00 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101213023430.GB21401@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pingc@wacom.com \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®