mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Matthias Schniedermeyer <ms@citd.de>,
	Luben Tuikov <ltuikov@yahoo.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] [USB] UASP: USB Attached SCSI (UAS) protocol driver
Date: Mon, 13 Dec 2010 22:53:25 +0100	[thread overview]
Message-ID: <20101213215324.GA6565@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <20101213194841.GA20997@citd.de>

I was just chilling down late in the evening by reading a short LKML 
overview, and then inadvertently managed to hit this bomb shell ;)

> As uas has not been in a release-kernel, by definition, there is no 
> impact either way. No regressions or anything else.

Since I've actually just been oldconfig'ing uas driver yesterday on a new 
installation, I can relate to UAS kernel support being quite new 
in its entirety.

If this is the case, then I'd also tend to believe the situation
is very different from other more painful (since longstanding) driver conflicts
(e.g. 8139, some raid drivers, and also e100 as witnessed by myself).

The author of UASP might want to adjust some of his writings
(especially the more personal parts),
however several parts of his criticism (e.g. no focus on code review)
seem valid from my POV.

If the new driver indeed is a whole lot better than the other newly
submitted/unreleased driver, then I'd fully welcome a reevaluation of the
situation.

For the author of the original submission this might of course be a
"less than positive" (to put it extreemely mildly) situation.
Still, I'd hope that there could be sufficient agreement on how to proceed
and how to make sure to have the most fitting code get into the kernel
and be maintained properly, ideally by continued interest by _both_
authors (or perhaps via "personality firewalls" ;), obviously.

Alas, I'm feeling like I'm stating obvious blathering here.

Anyway, by now you know which direction I'm tending in, despite the
not terribly warm writings by a certain author ;)

Disclaimer: no code review (comparison) performed, sorry.
Disclaimer #2: as the author of a still-outstanding kernel patch
(uhm - hi Greg ;) I'm in a sufficiently unfavourable position to comment
on this...

Andreas Mohr

  parent reply	other threads:[~2010-12-13 21:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10 23:15 Luben Tuikov
2010-12-10 23:42 ` Alan Cox
2010-12-11  2:26   ` Luben Tuikov
2010-12-13 18:40     ` Mark Brown
2010-12-13 19:48       ` Matthias Schniedermeyer
2010-12-13 21:53         ` Luben Tuikov
2010-12-13 21:53         ` Andreas Mohr [this message]
2010-12-14  0:42           ` Sarah Sharp
2010-12-14  8:30             ` Luben Tuikov
2010-12-13 21:34       ` Luben Tuikov
  -- strict thread matches above, loose matches on Subject: below --
2010-12-14 17:25 Luben Tuikov
2010-12-14 18:12 ` Ben Gamari
2010-12-15 22:17   ` Luben Tuikov
2010-12-16  6:29   ` Andreas Mohr
2010-12-16  9:46     ` Luben Tuikov
2010-12-16 12:11       ` Andreas Mohr
2010-12-13 21:46 Luben Tuikov
2010-12-13 22:37 ` Matthew Dharm
2010-12-09  0:16 Luben Tuikov
2010-12-09  1:52 ` Greg KH
2010-12-09  2:26   ` Matthew Dharm
2010-12-06 17:05 Luben Tuikov
2010-12-06 17:09 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101213215324.GA6565@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=broonie@sirena.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ltuikov@yahoo.com \
    --cc=ms@citd.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®