From: "Toralf Förster" <toralf.foerster@gmx.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: ERROR: spaces required
Date: Mon, 13 Dec 2010 22:59:04 +0100 [thread overview]
Message-ID: <201012132259.05317.toralf.foerster@gmx.de> (raw)
In-Reply-To: <AANLkTi=oHyk3AF3eKP3Vm2Ywfb9WcgrurNrkYVKfc588@mail.gmail.com>
Miguel Ojeda wrote at 19:49:43
> 2010/12/13 Toralf Förster <toralf.foerster@gmx.de>:
> > Signed-off-by: Toralf Förster <toralf.foerster@gmx.de>
> > ---
> > kernel/acct.c | 20 ++++++++++----------
> > 1 files changed, 10 insertions(+), 10 deletions(-)
> >
...
> > - if (value==0) return 0;
> > - while ((s64)value > 0){
> > + if (value == 0) return 0;
>
> Newline here. Doesn't checkpatch.pl complain? It is an old rule:
>
> http://lxr.linux.no/linux+v2.6.36/Documentation/CodingStyle#L60
>
I'd like to do only one thing at a time - not one file at a time.
--
MfG/Kind regards
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
prev parent reply other threads:[~2010-12-13 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 18:12 Toralf Förster
2010-12-13 18:49 ` Miguel Ojeda
2010-12-13 21:59 ` Toralf Förster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012132259.05317.toralf.foerster@gmx.de \
--to=toralf.foerster@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®