From: Dan Carpenter <error27@gmail.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: tfransosi@gmail.com, kernel-janitors@vger.kernel.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND] [PATCH] kernel/panic.c: Fix two checkpatch.pl errors (whitespace cleanup)
Date: Tue, 14 Dec 2010 21:42:57 +0300 [thread overview]
Message-ID: <20101214184253.GB1639@bicker> (raw)
In-Reply-To: <1292345888-19129-1-git-send-email-toralf.foerster@gmx.de>
On Tue, Dec 14, 2010 at 05:58:08PM +0100, Toralf Förster wrote:
> nothing else
>
This patch is not helpful. I mean that in the sense that the code is
just as readable before and after. :/ Please only send patches that
make the code better.
Checkpatch.pl is a good tool for staging but outside of staging you
should only use it for [check]ing [patch]es. The problem is that
pointless churn clutters up the log and breaks git blame. In staging
that's Ok.
regards,
dan carpenter
next prev parent reply other threads:[~2010-12-14 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 16:58 Toralf Förster
2010-12-14 18:42 ` Dan Carpenter [this message]
2010-12-14 18:50 ` Toralf Förster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214184253.GB1639@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tfransosi@gmail.com \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®