From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Peter Huewe <PeterHuewe@gmx.de>
Cc: Nick Piggin <npiggin@kernel.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] include/linux: Add missing include / fix build failure
Date: Thu, 16 Dec 2010 10:31:41 +1100 [thread overview]
Message-ID: <20101216103141.6f0a418c.sfr@canb.auug.org.au> (raw)
In-Reply-To: <201012152204.18881.PeterHuewe@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]
Hi Peter,
On Wed, 15 Dec 2010 22:04:18 +0100 Peter Huewe <PeterHuewe@gmx.de> wrote:
>
> From: Peter Huewe <peterhuewe@gmx.de>
>
> This patch fixes a build failure[1-2] by adding the missing asm/memory.h
> include needed for arch_is_coherent().
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> KernelVersion: linux-next-20101215
> Used configs: hackkit_defconfig (arm), ep93xx_defconfig (arm)
>
> References:
> [1] http://kisskb.ellerman.id.au/kisskb/buildresult/3651495/
> [2] http://kisskb.ellerman.id.au/kisskb/buildresult/3651425/
>
> Error Message:
> In file included from include/linux/list_bl.h:5,
> from include/linux/rculist_bl.h:7,
> from include/linux/dcache.h:7,
> from include/linux/fs.h:381,
> from arch/arm/mm/mmap.c:4:
> include/linux/bit_spinlock.h: In function 'bit_spin_unlock':
> include/linux/bit_spinlock.h:61: error: implicit declaration of function 'arch_is_coherent'
All (or most) of the above information should be in the commit message
(so above the "Signed-off-by").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-12-15 23:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 21:04 Peter Huewe
2010-12-15 23:31 ` Stephen Rothwell [this message]
2010-12-15 23:40 ` [PATCH v2] " Peter Hüwe
2010-12-16 2:41 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216103141.6f0a418c.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=PeterHuewe@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®