Re: [PATCH] Input: introduce device information ioctl

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Thu, Dec 16, 2010 at 09:30:13PM +0100, Henrik Rydberg wrote:
> Today, userspace sets up an input device based on the data it emits.
> This is not always enough; a tablet and a touchscreen may emit exactly
> the same data, for instance, but the former should be set up with a
> pointer whereas the latter does not need to. Recently, a new type of
> touchpad has emerged where the buttons are under the pad, which
> changes handling logic without changing the emitted data. This patch
> introduces a new ioctl, EVIOCGPROP, which enables user access to a set
> of device properties useful during setup. The properties are given as
> a bitmap in the same fashion as the event types, and are also made
> available via sysfs.
> 

Looks good to me.

Could you please also wire up /proc/bus/input/devices to show new
'props' (I think we could use  "B: PROP=" tags for them) and also to the
uevent handler?

Thanks.

-- 
Dmitry