From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH] vgaarb: use bridges to control VGA routing where possible. (v2)
Date: Mon, 20 Dec 2010 20:02:58 -0800 [thread overview]
Message-ID: <20101220200258.305889ec@jbarnes-desktop> (raw)
In-Reply-To: <1292803809-9200-1-git-send-email-airlied@gmail.com>
On Mon, 20 Dec 2010 10:10:09 +1000
Dave Airlie <airlied@gmail.com> wrote:
> - * @change_bridge: traverse ancestors and change bridges
> + * @change_bridge_flags: traverse ancestors and change bridges
> + * CHANGE_BRIDGE_ONLY / CHANGE_BRIDGE
> */
> int pci_set_vga_state(struct pci_dev *dev, bool decode,
> - unsigned int command_bits, bool change_bridge)
> + unsigned int command_bits, u32 flags)
> {
Other than this nitpick, it looks sound to me; we'll need to actually
disable VGA decode in the shared bridge hierarchy case rather than just
using simple bridge routing.
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2010-12-21 4:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 0:10 Dave Airlie
2010-12-21 4:02 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101220200258.305889ec@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®