From: Tejun Heo <tj@kernel.org>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: Andy Walls <awalls@md.metrocast.net>,
linux-kernel@vger.kernel.org, nicolas.mailhot@laposte.net,
Jarod Wilson <jarod@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [V3 PATCH] kthread_work: Make lockdep happy
Date: Wed, 22 Dec 2010 10:33:41 +0100 [thread overview]
Message-ID: <20101222093341.GA4684@htj.dyndns.org> (raw)
In-Reply-To: <20101222032305.GA30724@windriver.com>
On Wed, Dec 22, 2010 at 11:23:05AM +0800, Yong Zhang wrote:
> From: Yong Zhang <yong.zhang0@gmail.com>
> Subject: [V3 PATCH] kthread_work: Make lockdep happy
>
> spinlock in kthread_worker and wait_queue_head in kthread_work
> both should be lockdep sensible.
> So change the interface to make it suiltable for CONFIG_LOCKDEP.
>
> Reported-by: Nicolas <nicolas.mailhot@laposte.net>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> Signed-off-by: Andy Walls <awalls@md.metrocast.net>
> Tested-by: Andy Walls <awalls@md.metrocast.net>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
Applied with the following comment update (because the term "special
work" was a bit too confusing given the context) to wq#for-linus.
Will push out to Linus in several days.
+/*
+ * kthread_worker.lock and kthread_work.done need their own lockdep class
+ * keys if they are defined on stack with lockdep enabled. Use the
+ * following macros when defining them on stack.
+ */
Thank you.
--
tejun
next prev parent reply other threads:[~2010-12-22 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 12:49 [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep Andy Walls
2010-12-20 7:07 ` Yong Zhang
2010-12-20 9:28 ` Yong Zhang
2010-12-20 16:21 ` Tejun Heo
2010-12-21 1:54 ` Yong Zhang
2010-12-21 4:40 ` [V2 PATCH] kthread_work: Make lockdep happy Yong Zhang
2010-12-21 12:59 ` Tejun Heo
2010-12-21 13:25 ` Nicolas Mailhot
2010-12-21 16:07 ` Andy Walls
2010-12-22 0:39 ` Andy Walls
2010-12-22 3:12 ` Yong Zhang
2010-12-22 3:23 ` [V3 " Yong Zhang
2010-12-22 9:33 ` Tejun Heo [this message]
2010-12-20 17:16 ` [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep Andy Walls
2010-12-21 2:02 ` Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222093341.GA4684@htj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=awalls@md.metrocast.net \
--cc=hverkuil@xs4all.nl \
--cc=jarod@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mingo@redhat.com \
--cc=nicolas.mailhot@laposte.net \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome