From: Dominik Brodowski <linux@dominikbrodowski.net>
To: "Stano Lanči" <chl.pixo@gmail.com>
Cc: Belisko Marek <marek.belisko@gmail.com>,
Marek Belisko <marek.belisko@open-nandra.com>,
gregkh@suse.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: ft1000-pcmcia: Fix compilation errors.
Date: Wed, 22 Dec 2010 21:14:10 +0100 [thread overview]
Message-ID: <20101222201410.GA14419@comet.dominikbrodowski.net> (raw)
In-Reply-To: <AANLkTinD0f06h75dP9b9d8k3jZ2jbaYX2u=tRS4UWZbc@mail.gmail.com>
Hey,
On Wed, Dec 22, 2010 at 05:14:14PM +0100, Stano Lanči wrote:
> I reviewed your suggestion to use pcmcia_get_mac_from_cis().
> The problem is we need net_device structure and we create it
> in init_ft1000_card() that needs the mac address as one input parameter.
> I can move the code for it to ft1000_hw.c that deals with network part of
> the code, but then if the pcmcia API change that file will also
> have to be reviewed.
If it isn't too much of a hassle to update ft1000_hw.c, I'd prefer that
approach, for I do not intend to change the pcmcia API in this regard. And
if I do, I'll feel responsible for fixing ft1000 as well :)
Best,
Dominik
next prev parent reply other threads:[~2010-12-22 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 8:13 [PATCH 0/2] Fix ft1000-pcmcia driver Marek Belisko
2010-12-17 8:13 ` [PATCH 1/2] staging: ft1000-pcmcia: Fix compilation errors Marek Belisko
2010-12-17 13:04 ` Dominik Brodowski
2010-12-17 13:16 ` Belisko Marek
[not found] ` <AANLkTinD0f06h75dP9b9d8k3jZ2jbaYX2u=tRS4UWZbc@mail.gmail.com>
2010-12-22 20:14 ` Dominik Brodowski [this message]
2010-12-17 8:13 ` [PATCH 2/2] staging: ft1000-pcmcia: Fix compilation warning Marek Belisko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222201410.GA14419@comet.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=chl.pixo@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®