From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Dan Carpenter <error27@gmail.com>
Cc: Russ Gorby <richardx.r.gorby@intel.com>,
Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: smatch stuff: serial: ifx6x60: oops on load
Date: Wed, 29 Dec 2010 16:41:34 +0000 [thread overview]
Message-ID: <20101229164134.7eb982a4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20101220091555.GR1936@bicker>
On Mon, 20 Dec 2010 12:15:55 +0300
Dan Carpenter <error27@gmail.com> wrote:
> Smatch complains that the ifx6x60 driver in linux-next has a NULL
> dereference.
>
> drivers/serial/ifx6x60.c +986 ifx_spi_spi_probe(27)
> error: potential null derefence 'pl_data'.
>
> 984 ifx_dev->spi_timer.function = ifx_spi_timeout;
> 985 ifx_dev->spi_timer.data = (unsigned long)ifx_dev;
> 986 ifx_dev->is_6160 = pl_data->is_6160;
> ^^^^^^^
> "pl_data" is always NULL at this point. Presumably this crashes on load
> every time.
Getting the platform enabling patch in is on the todo list but it depends
on some other bits which are also not yet in the tree.
is_6160 needs to go anyway as it's not what the platform data really
indicates.
next prev parent reply other threads:[~2010-12-29 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 9:15 Dan Carpenter
2010-12-29 16:41 ` Alan Cox [this message]
[not found] <4C5E6457CD7911469A07260381288C28CB379310@orsmsx502.amr.corp.intel.com>
[not found] ` <E1A1564674E5754FB00AB9AC949D5E3260EB004322@rrsmsx501.amr.corp.intel.com>
[not found] ` <72D8A09E39A89147BE9CFBB6F0C73C3061F523A532@rrsmsx501.amr.corp.intel.com>
[not found] ` <E1A1564674E5754FB00AB9AC949D5E3260EB09CDD7@rrsmsx501.amr.corp.intel.com>
2010-12-29 16:19 ` Gorby, Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101229164134.7eb982a4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richardx.r.gorby@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®