From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755565Ab1ACTwU (ORCPT ); Mon, 3 Jan 2011 14:52:20 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:60335 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680Ab1ACTwS (ORCPT ); Mon, 3 Jan 2011 14:52:18 -0500 Date: Mon, 03 Jan 2011 11:52:48 -0800 (PST) Message-Id: <20110103.115248.179942629.davem@davemloft.net> To: sedat.dilek@googlemail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sedat.dilek@gmail.com Subject: Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable From: David Miller In-Reply-To: <1294020104-17124-1-git-send-email-sedat.dilek@gmail.com> References: <1294020104-17124-1-git-send-email-sedat.dilek@gmail.com> X-Mailer: Mew version 6.3 on Emacs 23.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sedat Dilek Date: Mon, 3 Jan 2011 03:01:44 +0100 > WARNING: drivers/net/ksz884x.o(.data+0x18): Section mismatch in reference from the variable pci_device_driver to the function .init.text:pcidev_init() > The variable pci_device_driver references > the function __init pcidev_init() > If the reference is valid then annotate the > variable with __init* or __refdata (see linux/init.h) or name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console, > > This patch fixes the warning. > > Tested with linux-next (next-20101231) > > Signed-off-by: Sedat Dilek pcidev_init() should be marked __devinit instead of __init to fix this bug.