From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Lin Ming <ming.m.lin@intel.com>, Ingo Molnar <mingo@elte.hu>,
Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
robert.richter@amd.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] perf: Optimise topology iteration
Date: Mon, 3 Jan 2011 16:20:25 +0100 [thread overview]
Message-ID: <20110103152025.GB25713@one.firstfloor.org> (raw)
In-Reply-To: <1294052530.2016.52.camel@laptop>
On Mon, Jan 03, 2011 at 12:02:10PM +0100, Peter Zijlstra wrote:
> On Mon, 2010-12-27 at 23:38 +0800, Lin Ming wrote:
> > Currently we iterate the full machine looking for a matching core_id/nb
> > for the percore and the amd northbridge stuff , using a smaller topology
> > mask makes sense.
>
> Does topology_thread_cpumask() include offline cpus? I tried looking at
> it, but I cannot find any code clearing bits in that mask on offline.
The problem is not only at offline, but also at online between CPUs
going online. I don't think the patch is a good idea and it doesn't
even have any advantages either since this is a initialization only
slow path.
-Andi
next prev parent reply other threads:[~2011-01-03 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 15:38 Lin Ming
2011-01-03 11:02 ` Peter Zijlstra
2011-01-03 15:20 ` Andi Kleen [this message]
2011-01-04 7:13 ` Lin Ming
2011-01-04 6:18 ` Lin Ming
2011-01-04 12:06 ` Peter Zijlstra
2011-01-04 14:22 ` Borislav Petkov
2011-01-05 5:24 ` Lin Ming
2011-01-05 9:51 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103152025.GB25713@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®