Re: [PATCH] misc/cs5535: Fix section mismatch derived from cs5535_mfgpt_drv variable

[Sam Ravnborg <sam@ravnborg.org>]

On Mon, Jan 03, 2011 at 11:43:10AM -0800, Andrew Morton wrote:
> On Mon,  3 Jan 2011 03:51:28 +0100
> Sedat Dilek <sedat.dilek@googlemail.com> wrote:
> 
> > >From my build.log:
> > 
> > WARNING: drivers/misc/cs5535-mfgpt.o(.data+0x0): Section mismatch in reference from the variable cs5535_mfgpt_drv to the function .devinit.text:cs5535_mfgpt_probe()
> > The variable cs5535_mfgpt_drv references
> > the function __devinit cs5535_mfgpt_probe()
> > If the reference is valid then annotate the
> > variable with __init* or __refdata (see linux/init.h) or name the variable:
> > *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
> 
> Confused.  cs5535_mfgpt_probe() _does_ have a name of the form
> "*_probe", so why did it warn?

The varibale need to follow the naming scheme.
In this case the function was named *_probe - which has no significance
in the section mismatch checks.

> > variable with __init* or __refdata (see linux/init.h) or name the variable:
    ^^^^^^^^                                                          ^^^^^^^^^ 

	Sam