mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mourad De Clerck <mourad@aquazul.com>
Cc: Richard Purdie <rpurdie@linux.intel.com>,
	linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1
Date: Tue, 4 Jan 2011 14:36:51 -0800	[thread overview]
Message-ID: <20110104143651.8f6d62e0.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D145EB5.7090205@aquazul.com>

On Fri, 24 Dec 2010 09:49:57 +0100
Mourad De Clerck <mourad@aquazul.com> wrote:

> Add support for the MacBookPro7,1 (13" mid 2010) to the mbp_nvidia_bl
> driver.
> 
> Signed-off-by: Mourad De Clerck <mourad@aquazul.com>
> ---
>  drivers/video/backlight/mbp_nvidia_bl.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/backlight/mbp_nvidia_bl.c
> b/drivers/video/backlight/mbp_nvidia_bl.c
> index 9fb533f..9c44314 100644
> --- a/drivers/video/backlight/mbp_nvidia_bl.c
> +++ b/drivers/video/backlight/mbp_nvidia_bl.c
> @@ -335,6 +335,15 @@ static const struct dmi_system_id __initdata
> mbp_device_table[] = {
>  		},
>  		.driver_data	= (void *)&nvidia_chipset_data,
>  	},
> +	{
> +		.callback	= mbp_dmi_match,
> +		.ident		= "MacBookPro 7,1",
> +		.matches	= {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro7,1"),
> +		},
> +		.driver_data	= (void *)&nvidia_chipset_data,
> +	},
>  	{ }
>  };

I applied this, and now I'll unapply it because Matthew's patch series
"mbp_nvidia_bl: Remove DMI dependency" appears to make your change
obsolete.

I'll cc you on those three patches - it will be great if you are able
to find time to test them, thanks.


  reply	other threads:[~2011-01-04 22:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-24  8:49 Mourad De Clerck
2011-01-04 22:36 ` Andrew Morton [this message]
2011-01-11 16:42   ` mbp_nvidia_bl: Remove DMI dependency (was: Re: [PATCH,RESEND] backlight: mbp_nvidia_bl - add support for MacBookPro7,1) Mourad De Clerck
2011-01-11 16:48     ` Matthew Garrett
2011-01-11 17:05       ` Richard Hughes
2011-01-11 18:07         ` mbp_nvidia_bl: Remove DMI dependency Mourad De Clerck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110104143651.8f6d62e0.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=mourad@aquazul.com \
    --cc=rpurdie@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome