From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751353Ab1AEASl (ORCPT ); Tue, 4 Jan 2011 19:18:41 -0500 Received: from mail.openrapids.net ([64.15.138.104]:40058 "EHLO blackscsi.openrapids.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933Ab1AEASk (ORCPT ); Tue, 4 Jan 2011 19:18:40 -0500 Date: Tue, 4 Jan 2011 19:18:37 -0500 From: Mathieu Desnoyers To: Frederic Weisbecker Cc: LKML , Steven Rostedt , Ingo Molnar , Thomas Gleixner Subject: Re: [RFC patch 3/5] ftrace trace event add missing semicolumn Message-ID: <20110105001837.GA9737@Krystal> References: <20110104231629.996422888@efficios.com> <20110104232419.441463699@efficios.com> <20110105000005.GE2911@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110105000005.GE2911@nowhere> X-Editor: vi X-Info: http://www.efficios.com X-Operating-System: Linux/2.6.26-2-686 (i686) X-Uptime: 19:13:50 up 42 days, 5:16, 5 users, load average: 0.05, 0.01, 0.00 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker (fweisbec@gmail.com) wrote: > On Tue, Jan 04, 2011 at 06:16:32PM -0500, Mathieu Desnoyers wrote: > > Add a missing semicolumn at the end of a ftrace definition. > > > > We currently are not seeing any impact of this missing semicolumn because extra > > semicolumns appear all over the place in the code generated from TRACE_EVENT > > within ftrace stages. > > > > Signed-off-by: Mathieu Desnoyers > > CC: Steven Rostedt > > CC: Frederic Weisbecker > > CC: Ingo Molnar > > CC: Thomas Gleixner > > --- > > include/trace/ftrace.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Index: linux-2.6-lttng/include/trace/ftrace.h > > =================================================================== > > --- linux-2.6-lttng.orig/include/trace/ftrace.h > > +++ linux-2.6-lttng/include/trace/ftrace.h > > @@ -69,7 +69,7 @@ > > #undef DEFINE_EVENT > > #define DEFINE_EVENT(template, name, proto, args) \ > > static struct ftrace_event_call __used \ > > - __attribute__((__aligned__(4))) event_##name > > + __attribute__((__aligned__(4))) event_##name; > > But DEFINE_EVENT() calls are supposed to be ";" terminated, no? Currently yes, but if you look at the preprocessor output currently generated by the current TRACE_EVENT()/DEFINE_EVENT() scheme, there are useless ";" added all over the place. I have a patch later in my queue that proposes removal of these extra ";" as a cleanup of the TRACE_EVENT() semantic, but I'm keeping it for later because it removes the extra ";" at the end of each TRACE_EVENT() instance (and thus is more intrusive code-wise). Adding this semicolumn here ensures that all Ftrace macros are consistent wrt semicolumns. We can get away without consistency currently exactly because the current scheme adds many useless semicolumns between each TRACE_EVENT(). Thanks, Mathieu -- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com