mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Tsozik <tsozik@yahoo.com>
Cc: Pete Zaitcev <zaitcev@redhat.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mct_u232: added _ioctl, _msr_to_icount and _get_icount functions
Date: Wed, 5 Jan 2011 14:43:06 -0800	[thread overview]
Message-ID: <20110105224306.GB18452@kroah.com> (raw)
In-Reply-To: <87086.58416.qm@web65703.mail.ac4.yahoo.com>

On Mon, Dec 27, 2010 at 12:55:38PM -0800, Tsozik wrote:
> Pete,
> 
> You're absolutely right. My apology again, I re-checked values of MSR masks used to update icount counters and they all belong to upper MSR nibble, so they indeed track changes (not states). I took out counter increments from mct_u232_msr_to_state function and encapsulated them in the newly defined mct_u232_msr_to_icount function, effectively leaving the previous implementation of mct_u232_msr_to_state function intact. mct_u232_msr_to_icount uses delta nibble to track state changes. RM-60 testing showed the same levels as measured by PDM-2 in close proximity to RM-60. Please let me know if anything else needs to be corrected to roll this out,

Can you not attach the patch as a base64 attachment?  I can't apply it
as-is, because of that, sorry.

thanks,

greg k-h

  parent reply	other threads:[~2011-01-05 22:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27 20:55 Tsozik
2010-12-27 22:12 ` Pete Zaitcev
2010-12-28  4:04   ` Tsozik
2010-12-28  6:40     ` Pete Zaitcev
2010-12-28 15:15       ` Tsozik
2011-01-05 22:42       ` Greg KH
2011-01-05 22:43 ` Greg KH [this message]
2011-01-13  3:34 Vadim Tsozik
2011-02-04 19:35 ` Greg KH
2011-02-05  3:45   ` Tsozik
2011-01-16 15:50 Vadim Tsozik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105224306.GB18452@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tsozik@yahoo.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®