From: David Miller <davem@davemloft.net>
To: mathieu.desnoyers@efficios.com
Cc: rostedt@goodmis.org, nhorman@tuxdriver.com, fweisbec@gmail.com,
zhaolei@cn.fujitsu.com, linux-kernel@vger.kernel.org,
mingo@elte.hu, tglx@linutronix.de
Subject: Re: [PATCH] trace event skb remove duplicate null-pointer check
Date: Thu, 06 Jan 2011 10:15:44 -0800 (PST) [thread overview]
Message-ID: <20110106.101544.193712005.davem@davemloft.net> (raw)
In-Reply-To: <20110106175319.GA30610@Krystal>
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Thu, 6 Jan 2011 12:53:19 -0500
> The check for NULL skb in the kfree_skb trace event is a duplicate from the
> check already done in its only caller, kfree_skb(). Remove this duplicate check.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2011-01-06 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 17:53 Mathieu Desnoyers
2011-01-06 18:15 ` David Miller [this message]
2011-01-06 18:17 ` Frederic Weisbecker
2011-01-06 18:37 ` David Miller
2011-01-06 18:38 ` Mathieu Desnoyers
2011-01-06 18:47 ` Frederic Weisbecker
2011-01-09 21:10 ` [tip:perf/urgent] tracing: remove duplicate null-pointer check in skb tracepoint tip-bot for Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106.101544.193712005.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome