From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752412Ab1AFJ5K (ORCPT ); Thu, 6 Jan 2011 04:57:10 -0500 Received: from gir.skynet.ie ([193.1.99.77]:50171 "EHLO gir.skynet.ie" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752195Ab1AFJ5J (ORCPT ); Thu, 6 Jan 2011 04:57:09 -0500 Date: Thu, 6 Jan 2011 09:56:47 +0000 From: Mel Gorman To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , William Irwin Subject: Re: [RFC 3/5] tlbfs: Remove unnecessary page release Message-ID: <20110106095647.GC29257@csn.ul.ie> References: <08549e97645f7d6c2bcc5c760a24fde56dfed513.1292604745.git.minchan.kim@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <08549e97645f7d6c2bcc5c760a24fde56dfed513.1292604745.git.minchan.kim@gmail.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 18, 2010 at 02:13:38AM +0900, Minchan Kim wrote: > This patch series changes remove_from_page_cache's page ref counting > rule. page cache ref count is decreased in remove_from_page_cache. > So we don't need call again in caller context. > > Cc: William Irwin > Signed-off-by: Minchan Kim Other than the subject calling hugetlbfs tlbfs, I did not see any problem with this assuming the first patch of the series is also applied. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab