From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Claudio Scordino <claudio@evidence.eu.com>
Cc: starvik@axis.com, Jesper Nilsson <Jesper.Nilsson@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485
Date: Thu, 6 Jan 2011 13:34:55 +0000 [thread overview]
Message-ID: <20110106133455.2f6175c6@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4D257C87.4040400@evidence.eu.com>
> With this patch, TIOCSRS485 gets the same value across all
> architectures, making maintenance and portability of user-level code
> easier.
I don't see why this is worth doing - no application code should ever
hardcode the value.
> + case TIOCSRS485DEPR:
> + {
> + printk(KERN_DEBUG "The use of this ioctl is deprecated. Use TIOCSRS485 instead\n");
> + /* Fall through */
> + }
and letting everyone spew printks is not a good thing.
NAK
next prev parent reply other threads:[~2011-01-06 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 8:25 Claudio Scordino
2011-01-06 13:34 ` Alan Cox [this message]
2011-01-06 16:58 ` Claudio Scordino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106133455.2f6175c6@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Jesper.Nilsson@axis.com \
--cc=claudio@evidence.eu.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®