From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754778Ab1AFW1T (ORCPT ); Thu, 6 Jan 2011 17:27:19 -0500 Received: from xenotime.net ([72.52.115.56]:50584 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754580Ab1AFW1Q (ORCPT ); Thu, 6 Jan 2011 17:27:16 -0500 Date: Thu, 6 Jan 2011 14:27:14 -0800 From: Randy Dunlap To: Jesper Juhl Cc: Rakesh Iyer , tsoni@codeaurora.org, shubhrajyoti@ti.com, ccross@android.com, konkers@android.com, olof@lixom.net, achew@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver Message-Id: <20110106142714.f823dea8.rdunlap@xenotime.net> In-Reply-To: References: <1294351512-17035-1-git-send-email-riyer@nvidia.com> Organization: YPO4 X-Mailer: Sylpheed 2.7.1 (GTK+ 2.16.6; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote: > > +fail: > > + if (kbc->irq >= 0) > > + free_irq(kbc->irq, pdev); > > + if (kbc->idev) > > + input_free_device(kbc->idev); > > As far as I can tell input_free_device() deals gracefully with being > passed a null pointer, so the 'if' seems superfluous. > > > -- > Jesper Juhl http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. + Please trim replies to the relevant part(s) of patches. thnx, --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***