From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236Ab1AFWCJ (ORCPT ); Thu, 6 Jan 2011 17:02:09 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:37909 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751685Ab1AFWCI (ORCPT ); Thu, 6 Jan 2011 17:02:08 -0500 Date: Thu, 6 Jan 2011 22:00:17 +0000 From: Alan Cox To: Greg KH Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Kay Sievers Subject: Re: [GIT PATCH] TTY/serial merge for .38 Message-ID: <20110106220017.3c19f9e6@lxorguk.ukuu.org.uk> In-Reply-To: <20110106215404.GA30624@kroah.com> References: <20110106215404.GA30624@kroah.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > There was some arguing about the tty console detection patches, but as > the existing ioctl does not work properly, Kay's patch was accepted to > resolve this issue and allow systemd to correctly detect consoles. I > know Alan doesn't like this, but I feel it's the best way to solve the > issue (combined with the fact that there is no proposed other solution.) I'm a bit confused about this one Greg - all the distributions used the ioctl you refer to below for this purpose and have for years > This series also includes the long-out-of-tree ioctl that SUSE and > Debian have been dragging around in their kernels for the past 10+ > years. Thanks to Werner for finally submitting it in a mergable form. Which I believe means we don't need the sysfs patch as well - Kay ?