From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: Jan Beulich <JBeulich@novell.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"Herrmann3, Andreas" <Andreas.Herrmann3@amd.com>,
"Roedel, Joerg" <Joerg.Roedel@amd.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: use PCI method for enabling AMD extended config space before MSR method
Date: Fri, 7 Jan 2011 13:58:18 +0100 [thread overview]
Message-ID: <20110107125818.GB23185@elte.hu> (raw)
In-Reply-To: <20110106172834.GN4739@erda.amd.com>
* Robert Richter <robert.richter@amd.com> wrote:
> On 06.01.11 18:20:04, Robert Richter wrote:
> > On 06.01.11 11:57:35, Jan Beulich wrote:
> > > While both methods should work equivalently well for the native case,
> > > the Xen Dom0 case can't reliably work with the MSR one, since there's
> > > no guarantee that the virtual CPUs it has available fully cover all
> > > necessary physical ones.
> > >
> > > As per the suggestion of Robert Richter the patch only adds the PCI
> > > method, but leaves the MSR one as a fallback to cover new systems the
> > > PCI IDs of which may not have got added to the code base yet.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@novell.com>
> > > Cc: Robert Richter <robert.richter@amd.com>
> > > Cc: Joerg Roedel <Joerg.Roedel@amd.com>
> > > Cc: Andreas Herrmann <Andreas.Herrmann3@amd.com>
> > > Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> > >
> > > ---
> > > arch/x86/include/asm/amd_nb.h | 7 ++++++
> > > arch/x86/kernel/amd_nb.c | 7 ++++++
> > > arch/x86/kernel/aperture_64.c | 44 +++++++++++++++---------------------------
> > > arch/x86/pci/amd_bus.c | 30 ++++++++++++++++++++++++++++
> > > 4 files changed, 60 insertions(+), 28 deletions(-)
>
> Btw, the patch should be relative to tip/x86/amd-nb as there would be
> conflicts otherwise due to other changes.
that's upstream meanwhile, so a patch against -git or -tip would suffice.
Thanks,
Ingo
next prev parent reply other threads:[~2011-01-07 12:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 16:57 Jan Beulich
2011-01-06 17:20 ` Robert Richter
2011-01-06 17:28 ` Robert Richter
2011-01-07 12:58 ` Ingo Molnar [this message]
2011-01-07 13:33 ` Jan Beulich
2011-01-07 7:40 ` Jan Beulich
2011-01-07 9:59 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107125818.GB23185@elte.hu \
--to=mingo@elte.hu \
--cc=Andreas.Herrmann3@amd.com \
--cc=JBeulich@novell.com \
--cc=Joerg.Roedel@amd.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.richter@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®