From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722Ab1AGQ6T (ORCPT ); Fri, 7 Jan 2011 11:58:19 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:58544 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555Ab1AGQ6S (ORCPT ); Fri, 7 Jan 2011 11:58:18 -0500 Date: Fri, 7 Jan 2011 09:58:15 -0700 From: Grant Likely To: Richard Genoud Cc: spi-devel-general@lists.sourceforge.net, David Brownell , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi_imx.c: correct the test on platform_get_irq() return value Message-ID: <20110107165815.GA25446@angua.secretlab.ca> References: <1294410361-9092-1-git-send-email-richard.genoud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1294410361-9092-1-git-send-email-richard.genoud@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 07, 2011 at 03:26:01PM +0100, Richard Genoud wrote: > The test "if (spi_imx->irq <= 0)" is not testing the IRQ value, but the return value of platform_get_irq(). > As platform_get_irq() can return an error (-ENXIO) or the IRQ value it found, the test should be "if (spi_imx->irq < 0)" > > Signed-off-by: Richard Genoud Alright. Applied. g. > --- > drivers/spi/spi_imx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_imx.c b/drivers/spi/spi_imx.c > index 55a38e2..793ae99 100644 > --- a/drivers/spi/spi_imx.c > +++ b/drivers/spi/spi_imx.c > @@ -847,7 +847,7 @@ static int __devinit spi_imx_probe(struct platform_device *pdev) > } > > spi_imx->irq = platform_get_irq(pdev, 0); > - if (spi_imx->irq <= 0) { > + if (spi_imx->irq < 0) { > ret = -EINVAL; > goto out_iounmap; > } > -- > 1.7.1 >