From: Yong Wang <yong.y.wang@linux.intel.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "Song, Youquan" <youquan.song@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpa@linux.intel.com" <hpa@linux.intel.com>,
yong.y.wang@intel.com, "joe@perches.com" <joe@perches.com>,
"jbaron@redhat.com" <jbaron@redhat.com>,
"arjan@linux.intel.com" <arjan@linux.intel.com>,
"trenn@suse.de" <trenn@suse.de>, "Liu, Kent" <kent.liu@intel.com>,
"Guo, Chaohong" <chaohong.guo@intel.com>,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH v2 1/2] apic: Fix error interrupt report at all APs
Date: Sat, 8 Jan 2011 08:58:18 +0800 [thread overview]
Message-ID: <20110108005818.GA8502@ywang-moblin2.bj.intel.com> (raw)
In-Reply-To: <1294425713.2673.18.camel@sbsiddha-MOBL3.sc.intel.com>
> > --- a/arch/x86/include/asm/apicdef.h
> > +++ b/arch/x86/include/asm/apicdef.h
> > @@ -78,6 +78,7 @@
> > #define APIC_DEST_LOGICAL 0x00800
> > #define APIC_DEST_PHYSICAL 0x00000
> > #define APIC_DM_FIXED 0x00000
> > +#define APIC_DM_FIXED_MASK 0x00700
>
> It should be called APIC_DM_MASK. Other than that this patch looks good.
>
Right, since every delivery mode uses the same mask.
Acked-by: Yong Wang <yong.y.wang@intel.com>
-Yong
prev parent reply other threads:[~2011-01-08 1:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 16:36 [PATCH v2 0/2] apic: Fix error interrupt report at all APs when boot Youquan Song
2011-01-07 16:36 ` [PATCH v2 1/2] apic: Fix error interrupt report at all APs Youquan Song
2011-01-07 16:36 ` [PATCH v2 2/2] apic: Add print error interrupt reason Youquan Song
2011-01-07 18:41 ` [PATCH v2 1/2] apic: Fix error interrupt report at all APs Suresh Siddha
2011-01-08 0:58 ` Yong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110108005818.GA8502@ywang-moblin2.bj.intel.com \
--to=yong.y.wang@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=chaohong.guo@intel.com \
--cc=hpa@linux.intel.com \
--cc=jbaron@redhat.com \
--cc=joe@perches.com \
--cc=kent.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=trenn@suse.de \
--cc=yong.y.wang@intel.com \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®