From: Wim Van Sebroeck <wim@iguana.be>
To: Mike Waychison <mikew@google.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Priyanka Gupta <priyankag@google.com>
Subject: Re: [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO
Date: Sun, 9 Jan 2011 10:33:19 +0100 [thread overview]
Message-ID: <20110109093319.GI3801@infomag.iguana.be> (raw)
In-Reply-To: <AANLkTin_xvms=Md_F0Uj0X=Exj61-bPALwABGFMX27bu@mail.gmail.com>
Hi Mike,
> The cleanups above seem fine to me. What did you mean by "Change
> reboot_notifier by a platform shutdown" though? I see that you
> removed the reboot_notifier, which is fine for our purposes. Was this
> a suggestion to have this stuff get called from platform code if
> needed? Am I missing something?
The platform_driver struct has a shutdown operation which does the same
as the reboot_notifier. Since the code is smaller and since the binary is
smaller we prefer to use the shutdown operation. So I removed the
reboot_notifier and added the shutdown operation.
Kind regards,
Wim.
prev parent reply other threads:[~2011-01-09 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 0:58 Mike Waychison
2010-10-26 0:58 ` [PATCH 2/2] watchdog: Add TCO support for nVidia chipsets Mike Waychison
2011-01-07 8:26 ` Wim Van Sebroeck
2011-01-06 23:35 ` [PATCH 1/2] watchdog: Add support for sp5100 chipset TCO Mike Waychison
2011-01-07 8:23 ` Wim Van Sebroeck
2011-01-07 22:23 ` Mike Waychison
2011-01-09 9:33 ` Wim Van Sebroeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109093319.GI3801@infomag.iguana.be \
--to=wim@iguana.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mikew@google.com \
--cc=priyankag@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®