From: Tejun Heo <tj@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH UPDATED] workqueue: relax lockdep annotation on flush_work()
Date: Sun, 9 Jan 2011 17:34:23 -0500 [thread overview]
Message-ID: <20110109223423.GA26607@mtj.dyndns.org> (raw)
In-Reply-To: <201101032225.46714.rjw@sisk.pl>
On Mon, Jan 03, 2011 at 10:25:46PM +0100, Rafael J. Wysocki wrote:
> On Monday, January 03, 2011, Tejun Heo wrote:
> > On Mon, Jan 03, 2011 at 04:14:45PM +0100, Peter Zijlstra wrote:
> > > > Hmmm? The code applies the most strict contraints. If the workqueue
> > > > has a rescuer, flushing another work from the workqueue will always
> > > > trigger lockdep warning. The rule is relaxed only for workqueues
> > > > which aren't used for memory reclaiming && support parallel execution.
> > >
> > > Ah, ok. I read it like: if the current thread is a rescue thread.
> >
> > Ah, I see. Rafael, can you please verify the updated version is okay
> > too (it should be but just in case)?
>
> It still appears to be fine.
Applied to wq#fixes-2.6.38 with Tested-by and stable cc added.
Thank you.
--
tejun
prev parent reply other threads:[~2011-01-09 22:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 12:57 [PATCH] " Tejun Heo
2010-12-29 14:20 ` Rafael J. Wysocki
2011-01-03 9:31 ` Peter Zijlstra
2011-01-03 14:17 ` [PATCH UPDATED] " Tejun Heo
2011-01-03 14:54 ` Peter Zijlstra
2011-01-03 15:00 ` Tejun Heo
2011-01-03 15:14 ` Peter Zijlstra
2011-01-03 15:20 ` Tejun Heo
2011-01-03 15:29 ` Peter Zijlstra
2011-01-03 21:25 ` Rafael J. Wysocki
2011-01-09 22:34 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109223423.GA26607@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®