From: Dmitry Torokhov <dtor@vmware.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Show version information for built-in modules in sysfs
Date: Tue, 11 Jan 2011 11:03:39 -0800 [thread overview]
Message-ID: <20110111190338.GA1542@dtor-ws.eng.vmware.com> (raw)
In-Reply-To: <201012221132.41057.rusty@rustcorp.com.au>
On Tue, Dec 21, 2010 at 05:02:40PM -0800, Rusty Russell wrote:
> On Thu, 16 Dec 2010 08:30:19 am Dmitry Torokhov wrote:
> > Currently only drivers that are built as modules have their versions
> > shown in /sys/module/<module_name>/version, but this information might
> > also be useful for built-in drivers as well. This especially important
> > for drivers that do not define any parameters - such drivers, if
> > built-in, are completely invisible from userspace.
> >
> > This patch changes MODULE_VERSION() macro so that in case when we are
> > compiling built-in module, version information is stored in a separate
> > section. Kernel then uses this data to create 'version' sysfs attribute
> > in the same fashion it creates attributes for module parameters.
> >
...
>
> __used and unused seems overkill, and confused.
>
> Removed unused.
>
Rusty,
What is the status of the patch? It woudl be nice if it coudl make it
into .38.
Thanks!
--
Dmitry
prev parent reply other threads:[~2011-01-11 19:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 22:00 Dmitry Torokhov
2010-12-15 22:06 ` Alexey Dobriyan
2010-12-15 22:14 ` Dmitry Torokhov
2010-12-15 23:25 ` Alexey Dobriyan
2010-12-15 23:53 ` Dmitry Torokhov
2010-12-16 0:30 ` Dmitry Torokhov
2010-12-16 12:58 ` Alexey Dobriyan
2010-12-22 1:45 ` Rusty Russell
2010-12-22 1:02 ` Rusty Russell
2010-12-22 1:17 ` Dmitry Torokhov
2010-12-22 1:48 ` Rusty Russell
2010-12-23 0:38 ` Dmitry Torokhov
2010-12-23 2:27 ` Rusty Russell
2011-01-11 19:03 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111190338.GA1542@dtor-ws.eng.vmware.com \
--to=dtor@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome