From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102Ab1AKVOt (ORCPT ); Tue, 11 Jan 2011 16:14:49 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:55672 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756045Ab1AKVOr (ORCPT ); Tue, 11 Jan 2011 16:14:47 -0500 Date: Tue, 11 Jan 2011 21:14:36 +0000 From: Russell King - ARM Linux To: Jamie Iles Cc: linux-kernel@vger.kernel.org, Eric Miao , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/16] ARM: pxa: don't treat NULL clk as an error Message-ID: <20110111211436.GO11039@n2100.arm.linux.org.uk> References: <1294749833-32019-1-git-send-email-jamie@jamieiles.com> <1294749833-32019-10-git-send-email-jamie@jamieiles.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1294749833-32019-10-git-send-email-jamie@jamieiles.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 11, 2011 at 12:43:46PM +0000, Jamie Iles wrote: > clk_get() returns a struct clk cookie to the driver and some platforms > may return NULL if they only support a single clock. clk_get() has only > failed if it returns a ERR_PTR() encoded pointer. Good catch. Acked-by: Russell King