From: Randy Dunlap <rdunlap@xenotime.net>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
Alex Dubov <oakad@yahoo.com>
Subject: Re: [PATCH 1/4] scatterlist: new helper functions
Date: Tue, 11 Jan 2011 22:41:31 -0800 [thread overview]
Message-ID: <20110111224131.f0abcd0a.rdunlap@xenotime.net> (raw)
In-Reply-To: <1294800749.29447.2.camel@maxim-laptop>
On Wed, 12 Jan 2011 04:52:29 +0200 Maxim Levitsky wrote:
> > > /**
> > > - * sg_compare_to_buffer - compare contents of the data pointeted by sg table
> > > + * sg_compare_to_buffer - compare contents of the data covered by an sg table
> > > * to a kernel ram buffer
> > > - * @sg - the current sg entry
> > > - * @buffer - linear buffer to compare with
> > > - * @len - lenght of that buffer
> > > + * @sg: the current sg entry
> > > + * @buffer: linear buffer to compare with
> > > + * @len: length of that buffer
> >
> > Returns what??
> 0 if equal and 1 otherwise.
> Was too lazy to implement full strcmp compliance.
> Is that needed?
Not that I know of, just what the function returns was needed.
> All very fair comments.
> Will check everything once again.
> Thanks for a review!
>
> Best regards,
> Maxim Levitsky
>
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-01-12 6:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 23:36 [PATCH V2 0/4]: MEMSTICK: My 2 drivers for 2.6.38 inclusion Maxim Levitsky
2011-01-11 23:36 ` [PATCH 1/4] scatterlist: new helper functions Maxim Levitsky
2011-01-11 23:51 ` Randy Dunlap
2011-01-11 23:55 ` Andrew Morton
2011-01-11 23:58 ` Randy Dunlap
2011-01-12 2:52 ` Maxim Levitsky
2011-01-12 6:41 ` Randy Dunlap [this message]
2011-01-18 0:46 ` [PATCH] " Maxim Levitsky
2011-01-11 23:36 ` [PATCH 2/4] memstick: Add driver for Ricoh R5C592 card reader Maxim Levitsky
2011-01-11 23:36 ` [PATCH 3/4] memstick: add support for legacy memorysticks Maxim Levitsky
2011-01-11 23:36 ` [PATCH 4/4] memstick: add Alex Dubov to MAINTAINERS of the memstick core Maxim Levitsky
-- strict thread matches above, loose matches on Subject: below --
2011-03-04 4:16 [PATH 0/4] Memstick patches for 2.6.39 Maxim Levitsky
2011-03-04 4:16 ` [PATCH 1/4] scatterlist: new helper functions Maxim Levitsky
2011-03-06 7:29 ` FUJITA Tomonori
2011-03-06 15:14 ` Maxim Levitsky
2011-03-06 21:49 ` FUJITA Tomonori
2011-03-07 2:20 ` Maxim Levitsky
2011-03-09 17:24 ` Maxim Levitsky
2011-03-16 0:44 ` Andrew Morton
2011-03-16 2:35 ` FUJITA Tomonori
2011-03-16 4:18 ` Alex Dubov
2011-03-16 4:55 ` FUJITA Tomonori
2011-03-17 3:46 ` Alex Dubov
2011-03-17 3:57 ` James Bottomley
2011-03-16 22:33 ` Andrew Morton
2011-03-17 6:41 ` Alex Dubov
2011-03-17 13:17 ` Maxim Levitsky
2011-03-18 0:59 ` FUJITA Tomonori
2011-01-11 2:58 Alex Dubov
2011-01-11 1:50 MEMSTICK: My 2 drivers for 2.6.38 inclusion Maxim Levitsky
2011-01-11 1:50 ` [PATCH 1/4] scatterlist: new helper functions Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111224131.f0abcd0a.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=oakad@yahoo.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®