From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabien Marteau <fabien.marteau@armadeus.com>
Cc: Scott Moreau <oreaus@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver (fourth version)
Date: Tue, 11 Jan 2011 21:50:02 -0800 [thread overview]
Message-ID: <20110112055002.GB22944@core.coreip.homeip.net> (raw)
In-Reply-To: <4D2ACA17.5060708@armadeus.com>
On Mon, Jan 10, 2011 at 09:57:59AM +0100, Fabien Marteau wrote:
> Hi Dmitry,
>
> Thanks for the patch, I tested it on my platform and there is a little bug in irq request for the button :
>
> + error = request_threaded_irq(as5011->button_irq,
> + NULL, as5011_button_interrupt,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_RISING,
> + "as5011_button", as5011);
>
> Should be :
>
> + error = request_threaded_irq(as5011->button_irq,
> + NULL, as5011_button_interrupt,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> + "as5011_button", as5011);
>
> With this modification the patch is ok.
>
Great, I applied it.
Thanks.
--
Dmitry
prev parent reply other threads:[~2011-01-12 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:11 Fabien Marteau
2011-01-08 9:30 ` Dmitry Torokhov
2011-01-10 8:57 ` Fabien Marteau
2011-01-12 5:50 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112055002.GB22944@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=fabien.marteau@armadeus.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oreaus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®