From: Wolfram Sang <w.sang@pengutronix.de>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Tony Finch <dot@dotat.at>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] strncpy() will not \0 terminate result
Date: Thu, 13 Jan 2011 23:46:27 +0100 [thread overview]
Message-ID: <20110113224627.GA15000@pengutronix.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1101132332430.11347@swampdragon.chaosbits.net>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Thu, Jan 13, 2011 at 11:35:39PM +0100, Jesper Juhl wrote:
> Hi,
>
> Mpass() in scripts/unifdef.c has this code:
> strncpy(keyword, "if ", 4);
> this will fail to \0 terminate the destination.
> Following patch should fix that up.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Thanks for fixing those issues. If you could spend a few more seconds on the
subject line (missing sth like "scripts/unifdef"-prefix; I initially was
fearing the bug was in lib/string.c) and the commit-message (which reads like a
mail), that would be helpful for reviewers.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-01-13 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 22:35 Jesper Juhl
2011-01-13 22:46 ` Wolfram Sang [this message]
2011-01-13 22:48 ` Jesper Juhl
2011-01-14 0:25 ` Tony Finch
2011-01-16 14:07 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113224627.GA15000@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=dot@dotat.at \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®