From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754892Ab1ANJpG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 14 Jan 2011 04:45:06 -0500
Received: from mail-qw0-f46.google.com ([209.85.216.46]:50245 "EHLO
	mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756751Ab1ANJov (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 14 Jan 2011 04:44:51 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        b=tJO3bpfcgijfnipcNqNd43gwQRvIYTJBJIHmsSXPsgQOFuo3Ly4z8VKVw2DOf9OA4M
         hNl0cdPjPoA7NFb1772WK/0PxJCWfDRmUjlVGTOUdT50sn72E3q6GX2QUAPlokVTMu0d
         vK0nhoQKiMp07WQY4RrSr14AJi7m3AVV/qQvc=
Date: Fri, 14 Jan 2011 17:44:42 +0800
From: =?utf-8?Q?Am=C3=A9rico?= Wang <xiyou.wangcong@gmail.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: =?utf-8?Q?Am=C3=A9rico?= Wang <xiyou.wangcong@gmail.com>,
        Dave Anderson <anderson@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] /proc/kcore: fix seeking
Message-ID: <20110114094442.GB10219@cr0.nay.redhat.com>
References: <4D2B1AD5.9000707@redhat.com>
 <20110111160437.GF17312@hack>
 <20110111162317.GA1703@nowhere>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20110111162317.GA1703@nowhere>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 11, 2011 at 05:23:23PM +0100, Frederic Weisbecker wrote:
>On Wed, Jan 12, 2011 at 12:04:37AM +0800, Américo Wang wrote:
>> On Mon, Jan 10, 2011 at 09:42:29AM -0500, Dave Anderson wrote:
>> >From: Dave Anderson <anderson@redhat.com>
>> >
>> >Commit 34aacb2920667d405a8df15968b7f71ba46c8f18
>> >("procfs: Use generic_file_llseek in /proc/kcore")
>> >broke seeking on /proc/kcore.  This changes it back
>> >to use default_llseek in order to restore the original
>> >behavior.
>> >
>> >The problem with generic_file_llseek is that it only
>> >allows seeks up to inode->i_sb->s_maxbytes, which is
>> >2GB-1 on procfs, where the memory file offset values in
>> >the /proc/kcore PT_LOAD segments may exceed or start
>> >beyond that offset value.
>> >
>> 
>> Is the race solved? Using default_llseek() still races
>> with read_kcore() on fpos, AFAIK.
>
>Hmm, how does it race there?
>
>read_kcore() manipulates fpos, which can't be changed behind
>us inside the read callback as it's a snapshot. Also read_kcore()
>can change the value of fpos, which is writed back to file->fpos
>from sys_read().
>
>So the last resulting race here the natural one between
>seeking and reading, which is up to the user to take care
>of.

Hmm, I just read the changelog of commit
34aacb2920667d405a8df15968b7f71ba46c8f18, which claims to fix
the race. So anything changed in vfs layer after that?

Thanks.