From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Jianbin Kang <kjbmail@gmail.com>
Cc: "Américo Wang" <xiyou.wangcong@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: add global tags generation.
Date: Fri, 14 Jan 2011 17:47:38 +0800 [thread overview]
Message-ID: <20110114094738.GC10219@cr0.nay.redhat.com> (raw)
In-Reply-To: <AANLkTinp4x7i+771CQdCJQmEJthBjow3ZR305ie-iYHb@mail.gmail.com>
On Fri, Jan 14, 2011 at 05:43:51PM +0800, Jianbin Kang wrote:
>2011/1/14 Américo Wang <xiyou.wangcong@gmail.com>:
>> On Fri, Jan 14, 2011 at 03:13:01PM +0800, Jianbin Kang wrote:
>>>gnu global (http://www.gnu.org/software/global/) is a source code tagging system
>>>It is really cheap to support it in kbuild system.
>>>
>>
>> Looks pretty good,
>>
>> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>>
>> But... 1) you missed your Signed-off-by; 2) you should Cc linux-kbuild
>> rather than trivial.
>er, where should signed-off-by be put? At the bottom of the mail or
>the bottom of the patch?
Usually, it is at the bottom of the patch description,
see Documentation/SubmittingPatches.
prev parent reply other threads:[~2011-01-14 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 7:13 Jianbin Kang
2011-01-14 9:33 ` Américo Wang
2011-01-14 9:43 ` Jianbin Kang
2011-01-14 9:47 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114094738.GC10219@cr0.nay.redhat.com \
--to=xiyou.wangcong@gmail.com \
--cc=kjbmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®